Skip to content

Add more project criteria #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

Add more project criteria #2139

merged 2 commits into from
Jul 14, 2025
+43 −17

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Jul 11, 2025

Closes #2133

@jennybc jennybc requested a review from hadley July 11, 2025 23:04
@jennybc jennybc mentioned this pull request Jul 11, 2025
Open
hadley
hadley approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to check for air.toml too?

@jennybc
Copy link
Member Author

jennybc commented Jul 14, 2025

Do we want to check for air.toml too?

My instinct is "no" and @DavisVaughan and @lionel- confirm that there might be reasons to have air.toml at multiple locations in the hierarchy or in non-root locations. So it doesn't feel like the right thing to do ... at least not now.

@jennybc jennybc merged commit d742c4e into main Jul 14, 2025
15 checks passed
@jennybc jennybc deleted the recognize-more-proj-roots branch July 14, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refresh proj detection criteria
2 participants
@jennybc @hadley